Don't check for donors when fitting MissingDataImputer (use the strategy to check) #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thank you for the great work @27pchrisl! |
andrewdalpino
approved these changes
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
During the fit stage of
MissingDataImputer, it checks if there are donors: "Dataset must contain at least 1 donor per feature column.".This is true for every strategy except the
Constantstrategy, where you don't need donors.I checked, and every other strategy does its own check, throwing the right
Exceptionif the provided array is empty.This PR removes the check within
MissingDataImputerso it's possible to use theConstantstrategy with a dataset that has no donors.